Skip to content

[fix](typo) fix typo 'sucess' -> 'success' typo in meta_service_http response#62539

Closed
SAY-5 wants to merge 1 commit intoapache:masterfrom
SAY-5:fix-meta-service-sucess-typo
Closed

[fix](typo) fix typo 'sucess' -> 'success' typo in meta_service_http response#62539
SAY-5 wants to merge 1 commit intoapache:masterfrom
SAY-5:fix-meta-service-sucess-typo

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 16, 2026 •
edited by gavinchou
Loading

blocked by #61502

Proposed changes

HTTP response message in cloud/src/meta-service/meta_service_http.cpp line 377 reads:

"sucess to adjust rate limit"

Fixed to "success to adjust rate limit". String-literal-only change; no logic change.

Checklist

  • Does not affect any functionalities

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Apr 16, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Copy Markdown
Contributor

yiguolei commented Apr 16, 2026

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

PR approved by anyone and no changes requested.

@morningman morningman self-assigned this Apr 17, 2026
@SAY-5 @morningman
[fix](cloud) fix 'sucess' -> 'success' typo in meta_service_http rate…
4b7a99b 
…-limit response

HTTP response in cloud/src/meta-service/meta_service_http.cpp line 377 read 'sucess to adjust rate limit'. Fixed to 'success'. String-literal-only change.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@morningman morningman force-pushed the fix-meta-service-sucess-typo branch from 65f86c3 to 4b7a99b Compare April 17, 2026 21:00
@morningman
Copy link
Copy Markdown
Contributor

morningman commented Apr 17, 2026

run buildall

@morningman
Copy link
Copy Markdown
Contributor

morningman commented Apr 17, 2026

/review

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Apr 17, 2026

Cloud UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.48% (1798/2291)
Line Coverage 64.15% (32294/50345)
Region Coverage 65.07% (16245/24967)
Branch Coverage 55.60% (8684/15620)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

OpenCode automated review failed and did not complete.

Error: Review step was failure (possibly timeout or cancelled)
Workflow run: https://github.com/apache/doris/actions/runs/24586514489

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@zclllyybb
Copy link
Copy Markdown
Contributor

zclllyybb commented Apr 18, 2026

skip buildall

@gavinchou gavinchou changed the title [fix](cloud) fix 'sucess' -> 'success' typo in meta_service_http response [fix](typo) fix typo 'sucess' -> 'success' typo in meta_service_http response Apr 19, 2026
@gavinchou
Copy link
Copy Markdown
Contributor

gavinchou commented Apr 19, 2026

blocked by #61502, I request for change first and wait for #61502 merge

gavinchou
gavinchou requested changes Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge later

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Apr 19, 2026
@gavinchou gavinchou self-requested a review April 19, 2026 15:25
@gavinchou
Copy link
Copy Markdown
Contributor

gavinchou commented Apr 19, 2026

@SAY-5 pls resolve the conflict.

@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 28, 2026

Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise.

@SAY-5 SAY-5 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41ter w41ter w41ter approved these changes

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees

@morningman morningman

Labels

dev/4.1.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SAY-5 @hello-stephen @yiguolei @morningman @zclllyybb @gavinchou @w41ter